Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][pom]chore: update mysql dependency #14736

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

Gallardot
Copy link
Member

@Gallardot Gallardot commented Aug 11, 2023

Purpose of the pull request

ref: #14683

ref: https://dev.mysql.com/doc/connector-j/en/connector-j-installing-maven.html

You can link the Connector/J library to your project by adding the following dependency in your pom.xml file:

<dependency>
    <groupId>com.mysql</groupId>
    <artifactId>mysql-connector-j</artifactId>
    <version>x.y.z</version>
</dependency>

Note
For Connector/J 8.0.29 and earlier, use the following Maven coordinates:

groupId: mysql

artifactId: mysql-connector-java

now we using Connector/J 8.4.0

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.79%. Comparing base (ebcdaeb) to head (8130f2e).

❗ Current head 8130f2e differs from pull request most recent head 2ad967a. Consider uploading reports for the commit 2ad967a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #14736   +/-   ##
=========================================
  Coverage     39.79%   39.79%           
  Complexity     5044     5044           
=========================================
  Files          1353     1353           
  Lines         45619    45619           
  Branches       4891     4891           
=========================================
  Hits          18156    18156           
  Misses        25553    25553           
  Partials       1910     1910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Radeity
Copy link
Member

Radeity commented Aug 11, 2023

Dependency license check failed, and dependency +mysql-connector-java-8.0.30.jar appears, it's weird.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@caishunfeng caishunfeng added improvement make more easy to user or prompt friendly Waiting for user feedback Waiting for feedback from issue/PR author labels Aug 29, 2023
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Feb 27, 2024

@ruanwenjun
Copy link
Member

The link https://dev.mysql.com/doc/connector-j/8.1/en/connector-j-installing-maven.html is 404 and it seems this pr might bring incompatible problem.

@Gallardot
Copy link
Member Author

The link https://dev.mysql.com/doc/connector-j/8.1/en/connector-j-installing-maven.html is 404 and it seems this pr might bring incompatible problem.

@ruanwenjun

The current 8.0.33 version also has a cve vulnerability, updated to the latest 8.4.0 version.
ref link update to https://dev.mysql.com/doc/connector-j/en/connector-j-installing-maven.html

Copy link

sonarcloud bot commented May 1, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly Waiting for user feedback Waiting for feedback from issue/PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants