feat(scheduler): add csv support for get_file_metadata grpc method #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etolbakov
commented
Apr 29, 2024
| @@ -297,13 +298,24 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> SchedulerGrpc | |||
| // TODO shouldn't this take a ListingOption object as input? | |||
|
|
|||
| let GetFileMetadataParams { path, file_type } = request.into_inner(); | |||
| let file_format: Arc<dyn FileFormat> = match file_type.as_str() { | |||
| let file_format: Result<Arc<dyn FileFormat>, Status> = match file_type.as_str() { | |||
| "parquet" => Ok(Arc::new(ParquetFormat::default())), | |||
There was a problem hiding this comment.
I've noticed that in the benchmark there's slightly different default for parquet:
ParquetFormat::default().with_enable_pruning(Some(true))I wonder if we need consistency or it's ok to leave it as is?
etolbakov
commented
Apr 29, 2024
| _ => Err(tonic::Status::unimplemented( | ||
| "get_file_metadata unsupported file type", | ||
| )), | ||
| }?; |
There was a problem hiding this comment.
I had to drop the "short circuit" from here to resolve the rust compilation error:
Type mismatch [E0308] expected `Result<Arc<CsvFormat>, Status>`, but found `Result<Arc<ParquetFormat>, Status>` please let me know if there's a better way of doing it?
|
@andygrove
|
|
@andygrove just a ping in case this notification is lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
I was exploring the code and came across the
TODOabout thecsvfile format support. So decided to address it.Rationale for this change
The functionality extension.
What changes are included in this PR?
csv/tlbfile format supportAre there any user-facing changes?
No