changesreader /added fields & body support #266

kozlovzxc · 2021-04-17T13:46:42Z

Overview

This PR is addressing issue #263

In simple words, it is adding support for fields and body params for changesreader.

Testing recommendations

You can run this code against any running CouchDB database e.g. https://registry.npmjs.org/

db.changesReader
  .start({ fields })
  .on('changes', console.log);

GitHub issue number

#263

Checklist

Code is written and works correctly;
Changes are covered by tests;
Documentation reflects the changes;

glynnbird · 2021-08-25T10:02:08Z

lib/nano.d.ts

    /** a MangoSelector defining the slice of the changes feed to return */
    selector?: MangoSelector;
+    /** a MangoSelector defining changes feed fields to return */


A small error: this isn't a MangoSelector, it's an array. :)

glynnbird · 2021-08-25T10:06:29Z

lib/changesreader.js

+            if (self.selector) {
+              req.body.selector = self.selector
+            }
+            if (self.fields) {


I don't see anything in the CouchDB docs saying that a fields array can be supplied. Am I missing something?

kozlovzxc added 2 commits April 17, 2021 13:35

fix(changesreader): added fields & body support

e3cc3a3

feat(common): added changesreader params docs

c7f964a

glynnbird requested changes Aug 25, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

changesreader /added fields & body support #266

changesreader /added fields & body support #266

kozlovzxc commented Apr 17, 2021

glynnbird Aug 25, 2021

glynnbird Aug 25, 2021

changesreader /added fields & body support #266

Are you sure you want to change the base?

changesreader /added fields & body support #266

Conversation

kozlovzxc commented Apr 17, 2021

Overview

Testing recommendations

GitHub issue number

Checklist

glynnbird Aug 25, 2021

Choose a reason for hiding this comment

glynnbird Aug 25, 2021

Choose a reason for hiding this comment