Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _dbs_info instead of fetching the db info one-by-one #1295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdahlbac
Copy link

@sdahlbac sdahlbac commented Oct 3, 2020

Overview

Slight efficiency improvement, use _dbs_info instead of fetching the info about the databases one by one.

Note, I'm by no means a react expert, so please let me know if I missed something or otherwise did something stupid.

Testing recommendations

Visit the all dbs page. It should work the same.

GitHub issue number

Fixes #1123

Related Pull Requests

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • Update rebar.config.script with the correct tag once a new Fauxton release is made

@sdahlbac
Copy link
Author

sdahlbac commented Oct 3, 2020

so, yeah I missed something since travis failed. I'll investigate

@wohali wohali changed the base branch from master to main October 30, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Get database information from _dbs_info
1 participant