MATH-1597: LowDiscrepancySequence supplier/jump for Halton and Sobol #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarlearning
suggested changes
Jul 5, 2021
| public void testFirstSupplying() { | ||
| LowDiscrepancySequence sequence = new SobolSequenceGenerator(3); | ||
| Assert.assertArrayEquals(new double[]{0.0, 0.0, 0.0}, sequence.get(),1e-6); | ||
|
|
There was a problem hiding this comment.
Please remove this newline
| @Test(expected = NotPositiveException.class) | ||
| public void testJumpNegativeIndex() { | ||
| LowDiscrepancySequence copyOfSeq = generator.jump(-5); | ||
|
|
There was a problem hiding this comment.
Please remove this newline
| public void testFirstSupplying() { | ||
| LowDiscrepancySequence sequence = new HaltonSequenceGenerator(3); | ||
| Assert.assertArrayEquals(new double[]{0.0, 0.0, 0.0}, sequence.get(),1e-6); | ||
|
|
There was a problem hiding this comment.
Please remove this newline
| @Test(expected = NotPositiveException.class) | ||
| public void testJumpNegativeIndex() { | ||
| LowDiscrepancySequence copyOfSeq = generator.jump(-5); | ||
|
|
There was a problem hiding this comment.
Please remove this newline
samyBadjoudj
force-pushed
the
feature/MATH-1597
branch
2 times, most recently
from
d85675f
to
0412ad3
Compare
|
done |
samyBadjoudj
force-pushed
the
feature/MATH-1597
branch
2 times, most recently
from
4ec560c
to
187bd46
Compare
|
check styles fixed |
amarlearning
suggested changes
Jul 10, 2021
|
|
||
|
|
||
|
|
||
| @Test |
There was a problem hiding this comment.
Can you please remove these 2 extra lines as well
| } | ||
|
|
||
|
|
| * @return the i-th point in the Halton sequence | ||
| * @throws org.apache.commons.math4.legacy.exception.NotPositiveException NotPositiveException if index < 0 | ||
| * @return the copy of this sequence | ||
| * @throws NotPositiveException if index < 0 |
There was a problem hiding this comment.
We can give the reference to the exception class as well org.apache.commons.math4.legacy.exception.NotPositiveException
| return weight != null ? (weight[i] * digit) % b : digit; | ||
| } | ||
|
|
||
| /** | ||
| * Skip to the i-th point in the Halton sequence. | ||
| * jump to the i-th point in the Halton sequence. |
samyBadjoudj
force-pushed
the
feature/MATH-1597
branch
from
187bd46
to
e7a8977
Compare
samyBadjoudj
force-pushed
the
feature/MATH-1597
branch
from
e7a8977
to
ac65dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.