Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGGING-189] Add optional import for package org.slf4j.spi #232

Merged
merged 1 commit into from Mar 17, 2024

Conversation

HannesWell
Copy link
Contributor

As suggested in #188 (comment).

@HannesWell
Copy link
Contributor Author

@garydgregory to answer your question in #188 (comment)

I do not know. Please test and/or provide a PR. I am about to create a release candidate for 1.3.1. I can always do a 1.3.2 but the turnaround on a release is at least 4 days.

It looks like it was not yet done. And yes I saw your preparatory commit for a release and assumed it will happen.
I have not yet tested this change, but I'm relatively confident it fixes the described problem from #188 (comment).
To save you work it would be great to include this into the upcoming release as well.

@garydgregory garydgregory merged commit 57d09eb into apache:master Mar 17, 2024
7 checks passed
@HannesWell HannesWell deleted the add-slf4j.spi-package branch March 17, 2024 15:40
@garydgregory
Copy link
Member

@HannesWell TY!
The release vote is here: https://lists.apache.org/thread/j4kfrdopkv8okroymbv86m1w40czgzys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants