CAY-2853 Incorrect deletion of entities from flattened attributes #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jugen
force-pushed
the
fix-deletion-of-entities-from-flattened-attribute
branch
from
bb796b9
to
ffa2791
Compare
|
This PR is ready for review please. |
stariy95
reviewed
May 9, 2024
cayenne/src/main/java/org/apache/cayenne/access/ObjectStore.java
Outdated
Show resolved
Hide resolved
cayenne/src/main/java/org/apache/cayenne/access/flush/RootRowOpProcessor.java
Outdated
Show resolved
Hide resolved
cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java
Outdated
Show resolved
Hide resolved
cayenne/src/test/java/org/apache/cayenne/access/DataContextFlattenedAttributesIT.java
Show resolved
Hide resolved
Jugen
force-pushed
the
fix-deletion-of-entities-from-flattened-attribute
branch
from
ffa2791
to
4189308
Compare
|
Have made all the changes as requested. Note that the changes to |
stariy95
approved these changes
May 9, 2024
Jugen
force-pushed
the
fix-deletion-of-entities-from-flattened-attribute
branch
from
4189308
to
338920e
Compare
|
Updated release notes and squashed commits for this PR. |
|
Now that this has been merged are there steps that I must take to back port this as previously suggested ? |
|
@Jugen I'll try to just cherry-pick this commit, and hope that it'll just apply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting an ObjEntity with flattened attributes Cayenne deletes the related DB attribute's row as well.
So if we have for example an ObjEntity "FlatPainting" with flattened attribute "galleryName". If we then delete a "FlatPainting" then the associated gallery will also be deleted, leaving all other paintings at that gallery without a valid Gallery link.
Furthermore if we add to our "FlatPainting" a "gallery" relationship attribute with delete rule Deny, the gallery was still being deleted.
The original intention was for something like a "PaintingFull" ObjEntity having all painting attributes and a flattened attribute to "PaintingInfo" as well, where the relationship is 1:1. In this case it makes sense that deleting a "PaintingFull" should also delete its associated PaintingInfo record.
In this PR a check has been added so that reverse toMany relationships are protected from deletion,
and if a relevant ObjRelationship is present then deletions are deferred to it instead.