Make EndpointRegistry extends Map<NormalizedEndpointUri, Endpoint>

[gnodet]

Change the CamelContext.getEndpointRegistry() to return an EndpointRegistry<NormalizedEndpointUri> instead of an EndpointRegistry<? extends ValueHolder<String>>.

This is a small incompatible change.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[davsclaus]

You can add a note about this API change in the Camel 4.7 upgrade page

[orpiske]

Probably a good one to run full tests on.

[davsclaus]

You likely need to update code at places like

camel-rest/src/main/java/org/apache/camel/component/rest/DefaultRestRegistry.java

[davsclaus]

You can do a

cd components
git grep getEndpointRegistry

[davsclaus]

this PR needs to fix in the components as commented above

[gnodet]

this PR needs to fix in the components as commented above

In theory yes, in practice, no component is affected. The reason is that the K generic type in the EnpointRegistry is only used on keySet() and entrySet() methods, which are not used, and components, when they need to access the registry do so without using an intermediate variable which could cause a cast compilation error.

I'm actually wondering if that parameter is needed at all, and while we're changing this method, it may be simpler to just make EndpointRegistry non parameterised and extends Map<NormalizedEndpointUri, Endpoint>. @davsclaus thoughts ?

[davsclaus]

this PR needs to fix in the components as commented above

In theory yes, in practice, no component is affected. The reason is that the K generic type in the EnpointRegistry is only used on keySet() and entrySet() methods, which are not used, and components, when they need to access the registry do so without using an intermediate variable which could cause a cast compilation error.

I'm actually wondering if that parameter is needed at all, and while we're changing this method, it may be simpler to just make EndpointRegistry non parameterised and extends Map<NormalizedEndpointUri, Endpoint>. @davsclaus thoughts ?

Yes that is better as we dont need other kind of parameters at all

[davsclaus]

org.apache.camel.issues.RecipientListUseOriginalMessageEndpointExceptionIssueTest.testRecipientListUseOriginalMessageIssue	1.822s	FAILURE
org.apache.camel.builder.xml.XPathTest.testXPathSplitConcurrent	1.763s	FAILURE