chore: Add Slack Kamelets E2E tests #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christophd
commented
May 13, 2024
christophd
commented
- Add serverUrl property to slack-source.kamelet for better testability reasons
- Use local Slack Http server in tests to verify Slack API calls
oscerd
reviewed
May 13, 2024
| @@ -37,6 +37,12 @@ spec: | |||
| - token | |||
| type: object | |||
| properties: | |||
| serverUrl: | |||
There was a problem hiding this comment.
Do we need to set it as required?
There was a problem hiding this comment.
no it should be optional
There was a problem hiding this comment.
in most cases this will connect to the production Slack API servers (which is also the default in the Camel component). Only tests and maybe a company proxy may use this setting to use a different server URL endpoint
christophd
force-pushed
the
chore/add-slack-e2e-tests
branch
from
1da7fcc
to
df16ff3
Compare
- Add serverUrl property to slack-source.kamelet for better testability reasons - Use local Slack Http server in tests to verify Slack API calls
christophd
force-pushed
the
chore/add-slack-e2e-tests
branch
from
df16ff3
to
88b3374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.