[CALCITE-6392] Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits the PostgreSQL toChar function off to its own function * Does not implement FX or TM prefix * Does not implement SP suffix * Timezone patterns are supported but all datetimes are in local timezone
…te/to_timestamp * First phase, mostly reorganizing classes * Does not yet implement to_date or to_timestamp * Fixed up fill mode handling * Isolated the unit test class so that it can make Locale changes safely * Introduced some new classes split out handling of some formats strings
normanj-bitquill
force-pushed
the
calcite-6392-rearrange
branch
from
0f93e5c
to
2f3c214
Compare
|
|
oops, I merged the wrong PR |
|
I have reverted these 6 commits merged by mistake in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is layered on top of
#3773
There will be subsequent PRs to further implement
to_dateandto_timestampfor PostgreSQL.