[CALCITE-6380] Casts from INTERVAL and STRING to DECIMAL are incorrect #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
caicancai
reviewed
May 21, 2024
| @@ -770,41 +773,39 @@ void testCastIntervalToNumeric(CastType castType, SqlOperatorFixture f) { | |||
| f.setFor(SqlStdOperatorTable.CAST, VmName.EXPAND); | |||
|
|
|||
| // interval to decimal | |||
| Expressions.constant(scale), | ||
| Expressions.constant(sourceType.getSqlTypeName().getEndUnit().multiplier)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we throw an exception when a situation does not include the above three cases
YiwenWu
reviewed
May 22, 2024
| // string to decimal | ||
| f.checkScalarExact("cast('1.29' as decimal(2,1))", | ||
| "DECIMAL(2, 1) NOT NULL", | ||
| "1.3"); | ||
| "1.2"); |
There was a problem hiding this comment.
Different systems have different interception methods, I think the return value 1.3 is also reasonable. Most systems return 1.3, such as MySQL, PostgreSQL, Hive, and Spark, but ClickHouse returns 1.2.
There was a problem hiding this comment.
There doesn't seem to be a standard set of sql rules here, so maybe we should think about what makes sense mathematically or what makes sense to follow the rules of most databases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.