Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6301] Extend ‘Must-filter’ columns to support a conditional … #3716

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CALCITE-6301] Extend ‘Must-filter’ columns to support a conditional … #3716

wants to merge 2 commits into from

Conversation

olivrlee
Copy link
Contributor

@olivrlee olivrlee commented Mar 7, 2024

…bypass list

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@olivrlee olivrlee marked this pull request as ready for review March 7, 2024 18:39
tanclary
tanclary reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@tanclary tanclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the style checks I think this looks really solid

core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
@@ -3894,32 +3894,37 @@ protected void validateSelect(

// Deduce which columns must be filtered.
ns.mustFilterFields = ImmutableBitSet.of();
ns.mustFilterBypassFields = ImmutableBitSet.of();
if (from != null) {
final Set<SqlQualified> qualifieds = new LinkedHashSet<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is qualifieds == qualifiedFields If so you could make it qualifiedFields and qualifiedBypassFields for consistency ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qualifieds are qualifiedMustFilterFields , yeah that could make it more clear

@mihaibudiu
Copy link
Contributor

@olivrlee can you please fix the style issues which prevent the CI from passing?

@olivrlee
Copy link
Contributor Author

@olivrlee can you please fix the style issues which prevent the CI from passing?

Sorry, I haven't had time to return to this.
There is one failing test case that I added in my last commit that I need to address before this will be ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanclary tanclary tanclary left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@olivrlee @mihaibudiu @tanclary