Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11205] bump com.google.cloud:libraries-bom to 16.3.0 #13937

Closed
wants to merge 1 commit into from

Conversation

masahitojp
Copy link
Contributor

@masahitojp masahitojp commented Feb 9, 2021

bump com.google.cloud:libraries-bom to 16.3.0
This changes required an update for "com.google.auto.value:auto-value-annotations:1.7.4", so I updated it.
I got a build error if I didn't update it.

R: @lukecwik @iemejia


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@masahitojp
Copy link
Contributor Author

Run SQL_Java11 PreCommit

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #13937 (adf4053) into master (ef685e6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13937      +/-   ##
==========================================
- Coverage   82.85%   82.85%   -0.01%     
==========================================
  Files         466      466              
  Lines       57613    57613              
==========================================
- Hits        47738    47737       -1     
- Misses       9875     9876       +1     
Impacted Files Coverage Δ
.../python/apache_beam/transforms/periodicsequence.py 96.49% <0.00%> (-1.76%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.57% <0.00%> (-0.26%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.54% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/io/iobase.py 84.81% <0.00%> (+0.26%) ⬆️
sdks/python/apache_beam/dataframe/schemas.py 96.87% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6edc333...adf4053. Read the comment docs.

@iemejia
Copy link
Member

iemejia commented Feb 10, 2021

@kennknowles This seems ok and it is passing all tests, it is good to merge for me but just wanted to double check with you in case there is some extra test that needs to be run or some extra validation at the G side.

@kennknowles
Copy link
Member

There is #13765 in progress

@kennknowles
Copy link
Member

CC @reuvenlax @suztomo

@kennknowles
Copy link
Member

There are actually some complications that are just about worked out there.

@kennknowles kennknowles self-requested a review February 10, 2021 17:10
@suztomo
Copy link
Contributor

suztomo commented Feb 10, 2021

I see #13765 takes care of dependency conflicts with "google-api-services-*" artifacts. Merging 13765 should meet the purpose of this PR 13937.

@kennknowles
Copy link
Member

It is merged. Try it out!

@masahitojp
Copy link
Contributor Author

The goal of this PR has been achieved by #13990 , so it's closed.

@masahitojp masahitojp closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants