Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc fix: GCP Installation Page - gke.md #2193

Open
wants to merge 2 commits into
base: v1.8.0
Choose a base branch
from

Conversation

moaxaca
Copy link

@moaxaca moaxaca commented Mar 23, 2024

Correcting the change from gateway.type -> ingress-controller.gateway.type to reflect the most recent helm chart.
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#L226C1-L228

Also adding some formatting to the command so it reads better.

Type of change:

  • Documentation

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Correcting the change from gateway.type -> service.type to reflect the most recent helm chart. 

Reference: https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L160-L162

Also adding some formatting to the command so it reads better.
@moaxaca moaxaca changed the title Update gke.md - GCP Installation Page doc fix: GCP Installation Page - gke.md Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant