Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loki-logger plugin support #2849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xdeadbeer
Copy link

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Add support for the loki-logger plugin.

Related issues

#2847

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #2849 (9776781) into master (e0290c8) will decrease coverage by 2.82%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 9776781 differs from pull request most recent head f17de1f. Consider uploading reports for the commit f17de1f to get more accurate results

@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
- Coverage   77.49%   74.68%   -2.82%     
==========================================
  Files         139      201      +62     
  Lines        3746     7848    +4102     
  Branches      881      881              
==========================================
+ Hits         2903     5861    +2958     
- Misses        843     1677     +834     
- Partials        0      310     +310     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.12% <ø> (?)
backend-unit-test 49.95% <ø> (?)
frontend-e2e-test 77.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/components/Plugin/data.tsx 100.00% <ø> (ø)
web/src/components/Plugin/Models.ts 100.00% <100.00%> (ø)
web/src/components/Plugin/modelCode.ts 100.00% <100.00%> (ø)

... and 62 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants