[AMORO-2827] Keep the same naming style as amoro-mixed-format-flink-runtime module #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2828 +/- ##
============================================
- Coverage 35.96% 32.78% -3.18%
- Complexity 386 3822 +3436
============================================
Files 46 558 +512
Lines 4708 46296 +41588
Branches 513 6177 +5664
============================================
+ Hits 1693 15176 +13483
- Misses 2847 29926 +27079
- Partials 168 1194 +1026
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhoujinsong
reviewed
May 13, 2024
There was a problem hiding this comment.
@xleoken Thanks for the contribution!
Should we rename the folder name of modules to keep the same with the new artifact ids?
@zhoujinsong, make sense, updated!
|
zhoujinsong
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2827 .
Brief change log
Keep the same naming style as amoro-mixed-format-flink-runtime module
amoro-mixed-format-flink-runtimemodulesHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation