Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2553] Parallelize reading of EQ delete files and cache them on optimizers #2584

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zhongqishang
Copy link
Contributor

Why are the changes needed?

Close #2553.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:core Core module module:mixed-hive Hive moduel for Mixed Format module:ams-optimizer AMS optimizer module labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 55.60976% with 91 lines in your changes are missing coverage. Please review.

Project coverage is 34.08%. Comparing base (92730de) to head (371a390).
Report is 5 commits behind head on master.

Files Patch % Lines
...tease/arctic/io/reader/OptimizerExecutorCache.java 5.17% 55 Missing ⚠️
...ase/arctic/io/reader/CombinedBaseDeleteLoader.java 76.11% 13 Missing and 3 partials ⚠️
...n/java/com/netease/arctic/utils/AmoroTypeUtil.java 26.31% 13 Missing and 1 partial ⚠️
...netease/arctic/io/reader/CombinedDeleteFilter.java 84.00% 1 Missing and 3 partials ⚠️
...ic/io/reader/GenericCombinedIcebergDataReader.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2584      +/-   ##
============================================
- Coverage     34.71%   34.08%   -0.64%     
+ Complexity     4521     4397     -124     
============================================
  Files           608      608              
  Lines         50980    50919      -61     
  Branches       6686     6678       -8     
============================================
- Hits          17700    17354     -346     
- Misses        31827    32159     +332     
+ Partials       1453     1406      -47     
Flag Coverage Δ
core 32.36% <55.60%> (-0.71%) ⬇️
trino 50.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added type:build and removed module:mixed-hive Hive moduel for Mixed Format labels Mar 21, 2024
@github-actions github-actions bot added module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format module:mixed-hive Hive moduel for Mixed Format labels Mar 21, 2024
@github-actions github-actions bot added module:ams-server Ams server module and removed module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format type:build labels Mar 25, 2024
@zhongqishang zhongqishang changed the title [AMORO-2553] Read eq delete files with cache them on executors [AMORO-2553] Parallelize reading of EQ delete files and cache them on optimizers Mar 25, 2024
@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-optimizer AMS optimizer module module:ams-server Ams server module module:core Core module module:mixed-hive Hive moduel for Mixed Format type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: The optimizer adds a cache of eq delete files to reduce repeated IO cost of eq delete files
1 participant