[AMORO-2438] Mixed Format KeyedTable support bin-packing splitting optimizing tasks #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangtaohz
commented
Dec 18, 2023
| @@ -146,14 +147,14 @@ public List<TaskDescriptor> planTasks() { | |||
| double avgThreadCost = actualInputSize / availableCore; | |||
| List<TaskDescriptor> tasks = Lists.newArrayList(); | |||
| for (AbstractPartitionPlan partitionPlan : actualPartitionPlans) { | |||
| tasks.addAll(partitionPlan.splitTasks((int) (actualInputSize / avgThreadCost))); | |||
| tasks.addAll(partitionPlan.splitTasks((int) (partitionPlan.getCost() / avgThreadCost))); | |||
There was a problem hiding this comment.
Fix calculating the target task count for each partition.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2446 +/- ##
============================================
+ Coverage 32.57% 32.59% +0.01%
+ Complexity 4469 4466 -3
============================================
Files 599 599
Lines 50306 50330 +24
Branches 6681 6687 +6
============================================
+ Hits 16388 16403 +15
- Misses 32614 32622 +8
- Partials 1304 1305 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wangtaohz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2438 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation