[AMORO-2273]: Fix highly memory usage when orphan file clean is enabled with too many manifest list file #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
zhoujinsong
reviewed
Nov 21, 2023
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2346 +/- ##
============================================
+ Coverage 53.46% 53.53% +0.07%
- Complexity 4358 4371 +13
============================================
Files 517 517
Lines 29861 29870 +9
Branches 2908 2909 +1
============================================
+ Hits 15964 15992 +28
+ Misses 12608 12590 -18
+ Partials 1289 1288 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shidayang
reviewed
Nov 29, 2023
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
|
Thanks @baiyangtx for contributions, I left some comment，BTW the ci is unpass |
# Conflicts: # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
|
CI unpass |
shidayang
reviewed
Dec 4, 2023
|
|
||
| ParallelIterable<StructLike> parallelIterable = | ||
| new ParallelIterable<>(transform, manifestIoExecutor); | ||
| parallelIterable.forEach( |
There was a problem hiding this comment.
ParallelIterable need close
# Conflicts: # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java # ams/server/src/main/java/com/netease/arctic/server/utils/IcebergTableUtil.java
…e' into fix-mixed-format-mem-highly-usage
…e' into fix-mixed-format-mem-highly-usage
wangtaohz
reviewed
Dec 7, 2023
ams/server/src/main/java/com/netease/arctic/server/utils/IcebergTableUtil.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2273.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation