Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2338] Incorrect display of props in hive upgrade page #2339

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shendanfengg
Copy link
Contributor

Why are the changes needed?

Close #2338 .

Brief change log

-Modify the filter for props

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (25cf7ae) 52.69% compared to head (e8ecc39) 52.69%.

Files Patch % Lines
...java/com/netease/arctic/table/TableProperties.java 0.00% 2 Missing ⚠️
...netease/arctic/server/dashboard/utils/AmsUtil.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2339   +/-   ##
=========================================
  Coverage     52.69%   52.69%           
+ Complexity     4219     4214    -5     
=========================================
  Files           511      510    -1     
  Lines         29333    29308   -25     
  Branches       2851     2851           
=========================================
- Hits          15456    15443   -13     
+ Misses        12632    12620   -12     
  Partials       1245     1245           
Flag Coverage Δ
core 53.04% <0.00%> (+0.01%) ⬆️
trino 50.87% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangtaohz
Copy link
Contributor

The title of the PR is supposed to be [AMORO-XXXX] @shendanfengg

@@ -243,6 +243,7 @@ public void getUpgradeHiveTableProperties(Context ctx) throws IllegalAccessExcep
AmsUtil.getNotDeprecatedAndNotInternalStaticFields(TableProperties.class);
tableProperties.keySet().stream()
.filter(key -> !key.endsWith("_DEFAULT"))
.filter(key -> tableProperties.containsKey(key + "_DEFAULT"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, properties without default values will be ignored. I'm curious to know which specific parameters need to be ignored in this way. Would it be appropriate to consider handling these parameters through HIDDEN_EXPOSED?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By my count there are close to 30 props that need to be filtered.

@shendanfengg shendanfengg changed the title [ARCTIC-2338] Incorrect display of props in hive upgrade page [AMORO-2338] Incorrect display of props in hive upgrade page Nov 21, 2023
@shendanfengg
Copy link
Contributor Author

The title of the PR is supposed to be [AMORO-XXXX] @shendanfengg
I've modified it.

@github-actions github-actions bot added the module:core Core module label Nov 21, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shendanfengg
❌ shendanfeng


shendanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module module:core Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect display of props in hive upgrade page
3 participants