Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1880] Mixed Hive Table can't Sync Hive data properly #1881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicochen
Copy link
Contributor

@nicochen nicochen commented Aug 23, 2023

Why are the changes needed?

fix #1880

Brief change log

The files in the Hive partition need to be synchronized into the Mixed Hive Table anyway.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:mixed-hive Hive moduel for Mixed Format label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45604a6) 50.79% compared to head (c11a1d8) 51.34%.
Report is 208 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1881      +/-   ##
============================================
+ Coverage     50.79%   51.34%   +0.55%     
+ Complexity     3802     3222     -580     
============================================
  Files           479      433      -46     
  Lines         25651    21280    -4371     
  Branches       2611     2101     -510     
============================================
- Hits          13029    10926    -2103     
+ Misses        11456     9422    -2034     
+ Partials       1166      932     -234     
Flag Coverage Δ
core 51.34% <100.00%> (+0.11%) ⬆️
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nicochen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-hive Hive moduel for Mixed Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mixed Hive Table can't Sync Hive data properly
2 participants