feat: enable mysql keda support for triggerer #37365
Open
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claneys
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
86d32d9
to
244fe48
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
7 times, most recently
from
a6aab9a
to
f0636e4
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
5 times, most recently
from
a0492f6
to
d804968
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
d804968
to
e54cdaf
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
5 times, most recently
from
b651318
to
b0e5375
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
3 times, most recently
from
cb956bb
to
e502d3c
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
7 times, most recently
from
51dd63c
to
5699e05
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
5 times, most recently
from
59093b4
to
5632a5d
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
6 times, most recently
from
01b0a81
to
d58108c
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
d58108c
to
4535f86
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
4535f86
to
d816009
Compare
|
Hi, Is there anything blocking this PR to be merge ? I might miss something. Thanks 🙏 cc: @jedcunningham |
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
2 times, most recently
from
6d2e6dd
to
cd3519e
Compare
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
2 times, most recently
from
da208a8
to
df85d20
Compare
Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
Also fix typo with worker tests targeting triggerer resources. Signed-off-by: Romain Forlot <romain.forlot@dailymotion.com>
claneys
force-pushed
the
feat/enable-mysql-keda-support-triggerer
branch
from
df85d20
to
d5b358e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the previous PR #36167 about MySQL Keda trigger support on workers and is the adaptation to the triggerer statefulset.