Do not crash when a version fails to parse #29685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old files on PyPI may contain version numbers that are non-standard and can't be properly parsed. Those are no longer allowed for new versions, so we can safely ignore those versions since they must be ancient.
uranusjr
requested review from
potiuk,
ashb and
jedcunningham
as code owners
eladkal
approved these changes
Feb 22, 2023
potiuk
approved these changes
Feb 22, 2023
|
Nice catch @uranusjr ! thanks! |
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 8, 2023
Old files on PyPI may contain version numbers that are non-standard and can't be properly parsed. Those are no longer allowed for new versions, so we can safely ignore those versions since they must be ancient. (cherry picked from commit 8430d60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old files on PyPI may contain version numbers that are non-standard and can't be properly parsed. Those are no longer allowed for new versions, so we can safely ignore those versions since they must be ancient.
The error is hit by #29644