New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(golang driver): add some comments for use with GoDoc #1504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is necessary. Thoughts? Justifications?
hmm perhaps writing examples could be more beneficial, made that PR because the driver felt somewhat confusing to me at first. see other database libraries on godoc for comparison, like pgx or go-sqlite3 |
Though if it may cause any merge conflict with anything that changes the codebase, please just merge the code changes first and then I'd happily rebase and remove any outdated comments |
@mjholub You should be able to rebase your PR's local branch with the AGE master and then do a force push to your remote mjholub:go-driver-documentation branch. That will cause the PR to be updated and should restart all of the PR checks. |
@jrgemignani yeah I know, it appears there are no conflicts though |
@mjholub Please fill out the optional extended description with a brief (few lines) description of your changes. You will likely need to do this locally and force push it to your remote branch to update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request addition of extending commit description.
@mjholub Can you please make the update so that I can merge the PR :) |
I'll take care of it soon |
This PR is stale because it has been open 45 days with no activity. Remove "Abondoned" label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for further 7 days with no activity |
some formatting changes were made automatically with gofumpt