Order some regression tests for stability on big-endian #1503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian's s390x architecture, some regression tests were failing because the result set was reordered. Fix by attaching ORDER BY in problematic cases.
On top of this change, another fix is required:
agtype_hash_cmp()
changes values on big-endian architectures. For Debian, I fixed it by adding aregress/expected/agtype_1.out
alternate output file where the diff to the original output file is this:With that extra file, AGE passes all regression tests on apt.postgresql.org:
https://pgdgbuild.dus.dg-i.net/job/postgresql-16-age-binaries/
But maintaining a full
agtype.out
file along with a fullagtype_1.out
will be painful, so some other solution will be needed.agtype_hash_cmp
tests to a separate test file, so only these tests would need two files<> 0
or similar)agtype_hash_cmp
to output the same value on all architecturesI can help implementing this, but I can't really decide which one of these options fits best. (The least intrusive version would probably option 1.)