-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: anymaniax#352 support allOf #861
base: master
Are you sure you want to change the base?
feat: anymaniax#352 support allOf #861
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel. @anymaniax first needs to authorize it. |
@anymaniax Resubmitted a fix pull request for allOf. I have rewritten it to a simpler code, so please consider it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anymaniax Thanks for the review. I replied.
83bc420
to
321788f
Compare
I did other test with more complex specification. I got a RangeError: Maximum call stack size exceeded. |
@anymaniax Can I have the Swagger file that I tested here? |
I cannot share it but will try to do a reproduction of the issue |
@anymaniax In specs where the elements of objects and arrays are cyclically referenced, as expected. I wonder if the recursive function never ends. Is that API realistic? |
Status
READY
Fix #352
Description
fix allOf type definition
e.g. #352
Related PRs
#503
Change
before
after