Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): 在排序中不将空字符串视为 undefined #2249

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

1wkk
Copy link
Contributor

@1wkk 1wkk commented Jun 11, 2023

👀 PR includes

🐛 Bugfix

🔧 Chore

  • Test case

📝 Description

not consider empty string as undefined, include empty string item in the sort action

🖼️ Screenshot

Before After
image image

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 9:03am

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 73.07% and project coverage change: -0.10% ⚠️

Comparison is base (1adc25d) 76.48% compared to head (7f8673e) 76.38%.
Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2249      +/-   ##
==========================================
- Coverage   76.48%   76.38%   -0.10%     
==========================================
  Files         240      240              
  Lines       12312    12447     +135     
  Branches     2630     2673      +43     
==========================================
+ Hits         9417     9508      +91     
+ Misses       1377     1371       -6     
- Partials     1518     1568      +50     
Files Changed Coverage Δ
packages/s2-core/src/cell/col-cell.ts 89.18% <ø> (-0.02%) ⬇️
packages/s2-core/src/cell/corner-cell.ts 83.33% <0.00%> (+0.64%) ⬆️
packages/s2-core/src/cell/row-cell.ts 73.57% <ø> (+0.23%) ⬆️
packages/s2-core/src/cell/table-col-cell.ts 86.53% <ø> (+4.72%) ⬆️
...ackages/s2-core/src/common/constant/interaction.ts 100.00% <ø> (ø)
packages/s2-core/src/data-set/base-data-set.ts 93.93% <ø> (+0.39%) ⬆️
packages/s2-core/src/data-set/pivot-data-set.ts 72.39% <0.00%> (-0.73%) ⬇️
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.30% <0.00%> (+0.19%) ⬆️
packages/s2-core/src/theme/index.ts 92.30% <ø> (-7.70%) ⬇️
packages/s2-core/src/utils/cell/data-cell.ts 77.08% <ø> (ø)
... and 33 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1wkk 1wkk changed the title fix(core): not consider empty string as undefined fix(core): 在排序中不将空字符串视为 undefined Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛交叉表自定义排序会将空字符串置底
2 participants