Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat: 支持从excel粘贴值进编辑表 #2148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serializedowen
Copy link
Member

@serializedowen serializedowen commented Apr 3, 2023

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Screen Recording 2023-04-03 at 16 31 45

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 8:39am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Size Change: +436 B (0%)

Total Size: 436 kB

Filename Size Change
./packages/s2-react/dist/index.min.js 67.9 kB +436 B (+1%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 172 kB
./packages/s2-core/dist/style.min.css 389 B
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.cjs.js 21.7 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.esm.js 21.2 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.js 60.3 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/@testing-library/dom.umd.min.js 33.9 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/config.js 1.16 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/DOMElementFilter.js 1.87 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/event-map.js 1.18 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/events.js 1.55 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/get-node-text.js 300 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-queries-for-element.js 738 B
./packages/s2-core/node_modules/@testing-library/dom/dist/get-user-code-frame.js 810 B
./packages/s2-core/node_modules/@testing-library/dom/dist/helpers.js 1.07 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/index.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/label-helpers.js 1.05 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/matches.js 1.14 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/pretty-dom.js 1.47 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/all-utils.js 337 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/alt-text.js 573 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/display-value.js 713 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/index.js 418 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/label-text.js 1.8 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/placeholder-text.js 491 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/role.js 2.67 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/test-id.js 498 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/text.js 958 B
./packages/s2-core/node_modules/@testing-library/dom/dist/queries/title.js 718 B
./packages/s2-core/node_modules/@testing-library/dom/dist/query-helpers.js 1.81 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/role-helpers.js 2.82 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/screen.js 1.51 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/suggestions.js 1.5 kB
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for-element-to-be-removed.js 748 B
./packages/s2-core/node_modules/@testing-library/dom/dist/wait-for.js 2.38 kB
./packages/s2-react/dist/style.min.css 3.42 kB
./packages/s2-vue/dist/index.min.js 20.5 kB
./packages/s2-vue/dist/style.min.css 1.68 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 45.76% and project coverage change: -0.13 ⚠️

Comparison is base (1adc25d) 76.48% compared to head (1e372f1) 76.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
- Coverage   76.48%   76.36%   -0.13%     
==========================================
  Files         240      241       +1     
  Lines       12312    12367      +55     
  Branches     2630     2637       +7     
==========================================
+ Hits         9417     9444      +27     
- Misses       1377     1399      +22     
- Partials     1518     1524       +6     
Impacted Files Coverage Δ
...act/src/components/sheets/editable-sheet/paste.tsx 34.88% <34.88%> (ø)
...act/src/components/sheets/editable-sheet/index.tsx 70.00% <50.00%> (+1.57%) ⬆️
...nteraction/brush-selection/base-brush-selection.ts 75.76% <70.00%> (+0.42%) ⬆️
...ction/brush-selection/data-cell-brush-selection.ts 87.03% <100.00%> (-0.47%) ⬇️
...interaction/brush-selection/row-brush-selection.ts 85.48% <100.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lijinke666 lijinke666 added the 🙏 need test cases or docs 需要单元测试或者补充文档 label Apr 20, 2023
@github-actions
Copy link
Contributor

你好 @serializedowen,感谢你的贡献, 为了让代码更健壮, 请补充相应单元测试, 如果有 API 改动, 请修改 相应的文档

Hello, @serializedowen, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.

@wjgogogo wjgogogo changed the title feat: 支持从excel粘贴值进编辑表 [WIP]feat: 支持从excel粘贴值进编辑表 Jun 16, 2023
@github-actions github-actions bot removed the pr(feature) new feature label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 need test cases or docs 需要单元测试或者补充文档
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🙏 支持从Excel复制一组cells值贴回S2
2 participants