Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(site): update element examples #5727

Merged
merged 4 commits into from May 12, 2024
Merged

docs(site): update element examples #5727

merged 4 commits into from May 12, 2024

Conversation

Aarebecca
Copy link
Contributor

基于 / Based on: #5726

  • 更新官网元素案例 / Update site element examples
image image image image image image

@@ -5,12 +5,12 @@
},
"demos": [
{
"filename": "circle.ts",
"filename": "circle.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怎么是 js ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前官网的例子都是 js,考虑两方面:

  1. 一个是尽可能确保用户复制过去可用,如果是 ts 的话,一些 js 用户复制过去是无法运行的
  2. 另一个是目前官网的编辑器是 js 编辑器,ts 代码虽然可以运行,但是有很多报错(以 js 语法检查),不太好看

@Aarebecca Aarebecca merged commit 454bc13 into v5 May 12, 2024
5 checks passed
@Aarebecca Aarebecca deleted the docs/examples-element branch May 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants