Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Toinane
Copy link

@Toinane Toinane commented Mar 18, 2022

Hey, just added Windows support (and maybe Linux too)

  • I had to change the toolbar to correspond to windows & macos
  • Add little more space between images rows
  • Add a dev script for Windows

@Toinane
Copy link
Author

Toinane commented Mar 18, 2022

Here the build for windows https://github.com/Toinane/image-optimizer/releases/tag/v1.3.2
Thank you for the application! Really useful to me 👍

@Toinane
Copy link
Author

Toinane commented Mar 18, 2022

should close #4

@antonreshetov
Copy link
Owner

@Toinane Thank you for the work you have done. But I would like to clarify. PR should not contain side changes, such as cosmetic changes or dependency version changes

@Uranite
Copy link

Uranite commented Mar 20, 2022

image
This error shows after I tried to optimize a folder

@Toinane
Copy link
Author

Toinane commented Mar 21, 2022

@antonreshetov I can't remove cosmetic change as you need to show Windows toolbar icons on the window to allow user to reduce and close your app. I see the toolbar on macos is from Electron's parameter in the BrowserWindows, but it don't show anything on Windows. Also I didn't edit anything about version changes, maybe just the yarn install when I did it. I can remove that from PR.

@Toinane
Copy link
Author

Toinane commented Mar 21, 2022

Weird issue @Uranite I didn't have this..
image

Are you on Win10 ? Have you tested another folder (like on the desktop) or just some files?

@antonreshetov
Copy link
Owner

@Toinane I indicated your commit cosmetic changes, here you have changed the height of the lines in the list

@Toinane
Copy link
Author

Toinane commented Mar 21, 2022

@Toinane I indicated your commit cosmetic changes, here you have changed the height of the lines in the list

Ah sorry, this was linked to the ToolbarVue, I thought that was it

@Toinane
Copy link
Author

Toinane commented Mar 21, 2022

Should be good now @antonreshetov

@Uranite
Copy link

Uranite commented Mar 21, 2022

Weird issue @Uranite I didn't have this.. image

Are you on Win10 ? Have you tested another folder (like on the desktop) or just some files?

Yeah windows 10, I think it might be because I already ran pingo (an image optimizer) before. I just tried taking a bunch of screenshots from minecraft and i ran the image optimizer and its fine

@antonreshetov
Copy link
Owner

image This error shows after I tried to optimize a folder

I faced a similar problem, but only if the folder name was in Cyrillic and only in Win. But unfortunately I do not have constantly Win machine to study the problem in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants