Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PLSQL DDL for Alter Database #4090

Conversation

@@ -4276,7 +4276,7 @@ general_recovery

//Need to come back to
full_database_recovery
: STANDBY? DATABASE (
: STANDBY? DATABASE? (
Copy link
Contributor

@kaby76 kaby76 May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. "full_database_recovery" seems to require the DATABASE token. https://docs.oracle.com/en/database/oracle/oracle-database/12.2/sqlrf/ALTER-DATABASE.html#GUID-8069872F-E680-4511-ADD8-A4E30AF67986__I2128285 . It is optional and the doc wrong? Also, can't the expression ( ( ... )+ )? following DATABASE in the rule be ( ... )*? (NB: I need to fix the script that detects useless parentheses as it flags the outer parens as useless, but it is not. https://github.com/antlr/grammars-v4/actions/runs/9044581722/job/24853394579#step:15:131 kaby76/g4-scripts#2 )

@teverett
Copy link
Member

@kaby76 this is not quite ready to merge yet?

@kaby76
Copy link
Contributor

kaby76 commented May 14, 2024

@kaby76 this is not quite ready to merge yet?

No, it's not quite ready. I still don't understand why the doc says DATABASE is required in full_database_recovery but here @ilyasahsan123 changed it to be optional. Please address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants