Should be umode_t

anthraxx · Apr 12, 2020 · 6cf4e76 · 6cf4e76
1 parent 9208097
commit 6cf4e76
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
@@ -42,7 +42,7 @@ int sysfs_restrict = IS_ENABLED(CONFIG_SECURITY_SYSFS_RESTRICT);
 int sysfs_create_dir_ns(struct kobject *kobj, const void *ns)
 {
 	struct kernfs_node *parent, *kn;
-	const char *mode;
+	umode_t *mode = S_IRWXU;
 	kuid_t uid;
 	kgid_t gid;
 
@@ -59,9 +59,7 @@ int sysfs_create_dir_ns(struct kobject *kobj, const void *ns)
 
 	kobject_get_ownership(kobj, &uid, &gid);
 
-	if (sysfs_restrict)
-		mode = S_IRWXU;
-	else
+	if (!sysfs_restrict)
 		mode = S_IRWXU | S_IRUGO | S_IXUGO;
 
 	kn = kernfs_create_dir_ns(parent, kobject_name(kobj),