This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Add support for multiple login buttons with different scopes + minor naming change #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliranamar
force-pushed
the
multi-button-scopes
branch
from
0ada5b0
to
7c8eb9a
Compare
eliranamar
commented
Dec 21, 2021
| | clientId | string | REQUIRED | You can create a clientID by creating a [new project on Google developers website.](https://developers.google.com/identity/sign-in/web/sign-in) | | ||
| | jsSrc | string | https://apis.google.com/js/api.js | URL of the Javascript file normally hosted by Google | | ||
| | hostedDomain | string | - | The G Suite domain to which users must belong to sign in | | ||
| | scope | string | profile email | Base scopes requested, Passing `scope` prop will be added additionally to `profile email`. Passing none will request only `profile email` | |
There was a problem hiding this comment.
Please view this file diff in rich text mode
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is not loading the scope passed via props when calling
window.gapi.auth2.init. instead let gapi load the default base scope (email profile), and when callingsignInmethod, add the required scopes if passed from props.This is helpful when using multiple buttons with different scopes.
Currently once gapi is loaded with 1 set of scope, then the same scope will be requested on every GoogleLogin instance.
Our specific use case was to add an offline access for google analytics in 1 place, and google ads access in another.