add speaking indicator feature for conference #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-media/Ant-Media-Server#6161
This PR adds ability to detect which participant is speaking in a conference room.
Speaking text will be displayed on right bottom of participants surface view renderer if their audioLevel is higher than a certain treshold.
Local participants audioLevel is not coming from datachannel. Seems like server only sends remote participants audio level through data channel.
To solve this local participants audio level is periodicly retrieved from webrtc clients stats collector.
TODO:
add testing after first review, because changes are not small