Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reset styles #7682

Merged
merged 7 commits into from Sep 22, 2017
Merged

update reset styles #7682

merged 7 commits into from Sep 22, 2017

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 20, 2017

close #4331

A lot of changes. Reset styles is not global after 3.0, you have to import it individually.


Reverted the reset.less idea. It will be a break change. The solution would be:

@codecov
Copy link

codecov bot commented Sep 20, 2017

Codecov Report

Merging #7682 into antd-3.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           antd-3.0   #7682   +/-   ##
========================================
  Coverage      82.1%   82.1%           
========================================
  Files           214     214           
  Lines          4453    4453           
  Branches       1342    1342           
========================================
  Hits           3656    3656           
  Misses          797     797

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c5849...4bd6d87. Read the comment docs.

@benjycui
Copy link
Contributor

And this will be a breaking change which should be noted in upgrade instructions.

@afc163 afc163 changed the title seperate reset styles [WIP] seperate reset styles Sep 21, 2017
@afc163
Copy link
Member Author

afc163 commented Sep 21, 2017

Make css usage complex...

@benjycui
Copy link
Contributor

Remove annoying reset styles like margin:0;padding:0; for every tags.

But it will break current systems' styles.. which had depended on these reset rules..

@afc163
Copy link
Member Author

afc163 commented Sep 22, 2017

I will document it in upgrade note.

@afc163 afc163 changed the title [WIP] seperate reset styles seperate reset styles Sep 22, 2017
@afc163 afc163 merged commit 759b0bb into antd-3.0 Sep 22, 2017
@afc163 afc163 deleted the optimize-reset-styles branch September 22, 2017 10:33
@afc163 afc163 changed the title seperate reset styles update reset styles Sep 22, 2017
@AleksandrZhukov
Copy link

@afc163 These changes make a lot of problems for using global css styles with the same specificity. For example it is impossible to set margin via global class that has same specificity .mb-10 { margin-bottom: 10px }
image
Is it possible to avoid of reseting such values?
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants