New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update reset styles #7682
update reset styles #7682
Conversation
Codecov Report
@@ Coverage Diff @@
## antd-3.0 #7682 +/- ##
========================================
Coverage 82.1% 82.1%
========================================
Files 214 214
Lines 4453 4453
Branches 1342 1342
========================================
Hits 3656 3656
Misses 797 797 Continue to review full report at Codecov.
|
And this will be a breaking change which should be noted in upgrade instructions. |
Make css usage complex... |
66e2a9b
to
6374e80
Compare
6374e80
to
f6254f2
Compare
But it will break current systems' styles.. which had depended on these reset rules.. |
I will document it in upgrade note. |
@afc163 These changes make a lot of problems for using global css styles with the same specificity. For example it is impossible to set margin via global class that has same specificity |
close #4331
A lot of changes. Reset styles is not global after 3.0, you have to import it individually.Reverted the
reset.less
idea. It will be a break change. The solution would be:margin:0;padding:0;
for every tags.label
in Form.