New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notification): add show progress option and update docs #48353
base: feature
Are you sure you want to change the base?
feat(notification): add show progress option and update docs #48353
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48353 Failed ❌
Check Full Report for details |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
1cb2dcd
to
e3751cd
Compare
the preview here https://preview-48353-ant-design.surge.sh/components/notification#notification-demo-show-progress doesn't show any progress indicator |
Yes, it's work in progress. I'm waiting for the dependence merged. The demo for rc-notification https://notification-git-fork-yociduo-feat-show-progess-react-component.vercel.app/demo/hooks |
e3751cd
to
e53f010
Compare
@yociduo lint 报错了,需要处理一下 |
修复了,不过需要先处理组件那边的更新。 |
我去催一下 rc-notification 那边 |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #48353 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 746 746
Lines 13014 13014
Branches 3426 3426
=========================================
Hits 13014 13014 ☔ View full report in Codecov by Sentry. |
|
||
[`&::-webkit-progress-value`]: { | ||
borderRadius: borderRadiusLG, | ||
background: `linear-gradient(90deg, #31afff, #1677ff)`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1677ff 可以用主色
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
找找 #31afff 和主色的关系?或者在 blue 里找一个类似的。
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #48125
react-component/notification#322
💡 Background and solution
📝 Changelog
showProgress
propshowProgress
属性☑️ Self-Check before Merge