Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2571 #2518 #2645 增加disabled属性及取消上传时cancel请求 #2690

Merged
merged 2 commits into from Aug 14, 2016

Conversation

@mention-bot
Copy link

@ddcat1115, thanks for your PR! By analyzing the annotation information on this pull request, we identified @afc163, @yiminghe and @benjycui to be potential reviewers

@ddcat1115 ddcat1115 changed the title fix #2571 #2518 #2645 fix #2571 #2518 #2645 增加disabled属性及取消上传时cancel请求 Aug 11, 2016
@afc163
Copy link
Member

afc163 commented Aug 12, 2016

https://github.com/ddcat1115/ant-design/blob/3f14cab15b45db4e66be8e87d64bbf4c4080262d/components/upload/index.jsx#L219

这里要比较一下新旧 list,消失的文件要 abort。(受控模式下移除文件)

@@ -66,7 +66,7 @@
vertical-align: middle;
}

&:hover {
&:not(.@{upload-prefix-cls}-disabled):hover {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充上 disabled 的 cursor: not-allowed; 样式。

@yiminghe
Copy link
Contributor

onStart 永远是一个文件维度了,同 onSuccess/onError。不会是数组

@afc163
Copy link
Member

afc163 commented Aug 12, 2016

那需要看下多选的兼容。@ddcat1115

@ddcat1115
Copy link
Contributor Author

果然 multiple 有问题了,onStart 得到的都是单个文件,上传多个调多次 onStart,fileList来不及更新

@yiminghe
Copy link
Contributor

'fileList来不及更新' 2.0.3 应该好了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants