Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug when the children is 0 and < Button > has icon prop , the width of component is wrong. #13596

Merged
merged 6 commits into from
Dec 20, 2018

Conversation

951565664
Copy link
Contributor

Fix the bug when the children is 0 and < Button > has icon prop , the width of component is wrong.

image

bug demo: https://codesandbox.io/s/0146v1lxkl

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your pull request, thank you!

  • Make sure that you propose pull request to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a pull request to keep commit history clear.
  • Add some descriptions and refer relative issues for you pull request.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

I am sorry that I have not been able to add a unit test because the enzyme cannot get the width of the component enzymejs/enzyme#1940

951565664 and others added 4 commits December 12, 2018 21:00
修复当值为0时样式不对问题 ,bug demo.https://codesandbox.io/s/0146v1lxkl
Fix the bug when the children is 0 and < Button > has icon prop , the width of component is wrong.
@netlify
Copy link

netlify bot commented Dec 12, 2018

Deploy preview for ant-design ready!

Built with commit e980539

https://deploy-preview-13596--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #13596 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13596      +/-   ##
==========================================
- Coverage   93.63%    93.6%   -0.04%     
==========================================
  Files         314      314              
  Lines        6631     6631              
  Branches     1767     1767              
==========================================
- Hits         6209     6207       -2     
- Misses        410      412       +2     
  Partials       12       12
Impacted Files Coverage Δ
components/button/button.tsx 93.4% <100%> (ø) ⬆️
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a66546...d3d8d03. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #13596 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13596      +/-   ##
==========================================
- Coverage   93.63%    93.6%   -0.04%     
==========================================
  Files         314      314              
  Lines        6631     6631              
  Branches     1767     1767              
==========================================
- Hits         6209     6207       -2     
- Misses        410      412       +2     
  Partials       12       12
Impacted Files Coverage Δ
components/button/button.tsx 93.4% <100%> (ø) ⬆️
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a66546...d3d8d03. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #13596 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13596      +/-   ##
==========================================
- Coverage   93.63%    93.6%   -0.04%     
==========================================
  Files         314      314              
  Lines        6631     6631              
  Branches     1767     1767              
==========================================
- Hits         6209     6207       -2     
- Misses        410      412       +2     
  Partials       12       12
Impacted Files Coverage Δ
components/button/button.tsx 93.4% <100%> (ø) ⬆️
components/upload/UploadList.tsx 88.49% <0%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a66546...d3d8d03. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #13596 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13596      +/-   ##
==========================================
- Coverage   93.65%    93.6%   -0.05%     
==========================================
  Files         314      314              
  Lines        6646     6631      -15     
  Branches     1742     1767      +25     
==========================================
- Hits         6224     6207      -17     
- Misses        411      412       +1     
- Partials       11       12       +1
Impacted Files Coverage Δ
components/button/button.tsx 93.4% <100%> (ø) ⬆️
components/radio/group.tsx 90.38% <0%> (-4.17%) ⬇️
components/badge/index.tsx 98.5% <0%> (-1.5%) ⬇️
components/table/SelectionCheckboxAll.tsx 92.3% <0%> (-0.29%) ⬇️
components/cascader/index.tsx 97.42% <0%> (-0.07%) ⬇️
components/badge/ScrollNumber.tsx 96.72% <0%> (-0.06%) ⬇️
components/menu/MenuItem.tsx 94.73% <0%> (ø) ⬆️
components/menu/index.tsx 94.06% <0%> (ø) ⬆️
components/menu/SubMenu.tsx 92.85% <0%> (ø) ⬆️
components/date-picker/WeekPicker.tsx 93.33% <0%> (+0.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb7bac...e980539. Read the comment docs.

@afc163 afc163 merged commit f5bf79d into ant-design:master Dec 20, 2018
@afc163 afc163 mentioned this pull request Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants