Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to prevent global styles pollution #11929

Merged
merged 6 commits into from Sep 2, 2018
Merged

docs: explain how to prevent global styles pollution #11929

merged 6 commits into from Sep 2, 2018

Conversation

abenhamdine
Copy link
Contributor

@abenhamdine abenhamdine commented Aug 28, 2018

Add explanation in docs (customize-theme) to how to prevent global styles pollution by configuring webpack.
Based on #4331 (comment)
This solution looks the best for people using webpack.

Add also another solution based on #4331 (comment)

Should help to decrease noise in #4331 ;)

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

Add explantion in docs (customize theme) to how to prevent global styles pollution by configuring webpabk.
Based on #4331 (comment)
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 28, 2018

Deploy preview for ant-design ready!

Built with commit 7a52640

https://deploy-preview-11929--ant-design.netlify.com

@abenhamdine abenhamdine changed the title Explain how to prevent global styles pollution docs: Explain how to prevent global styles pollution Aug 28, 2018
@abenhamdine abenhamdine changed the title docs: Explain how to prevent global styles pollution docs: explain how to prevent global styles pollution Aug 28, 2018
@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #11929 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11929   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         200      200           
  Lines        5192     5192           
  Branches     1451     1460    +9     
=======================================
  Hits         4777     4777           
- Misses        409      411    +2     
+ Partials        6        4    -2
Impacted Files Coverage Δ
components/transfer/index.tsx 87.41% <0%> (ø) ⬆️
components/time-picker/index.tsx 81.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b644008...7a52640. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Sep 2, 2018

Thx @abenhamdine, this workaround seem to a bit twist though we can suggest with it until find another solution.

@afc163 afc163 merged commit c2e2f02 into ant-design:master Sep 2, 2018
@abenhamdine
Copy link
Contributor Author

this workaround seem to a bit twist though we can suggest with it until find another solution.

Yes, you're right. IMHO the solution should be to use a less variable to optionnaly scope the global styles, I failed to find time to send according PR until now.

@afc163
Copy link
Member

afc163 commented Sep 3, 2018

ref #9363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants