New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain how to prevent global styles pollution #11929
Conversation
Add explantion in docs (customize theme) to how to prevent global styles pollution by configuring webpabk. Based on #4331 (comment)
Deploy preview for ant-design ready! Built with commit 7a52640 |
Codecov Report
@@ Coverage Diff @@
## master #11929 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 200 200
Lines 5192 5192
Branches 1451 1460 +9
=======================================
Hits 4777 4777
- Misses 409 411 +2
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
Thx @abenhamdine, this workaround seem to a bit twist though we can suggest with it until find another solution. |
Yes, you're right. IMHO the solution should be to use a less variable to optionnaly scope the global styles, I failed to find time to send according PR until now. |
ref #9363 |
Add explanation in docs (customize-theme) to how to prevent global styles pollution by configuring webpack.
Based on #4331 (comment)
This solution looks the best for people using webpack.
Add also another solution based on #4331 (comment)
Should help to decrease noise in #4331 ;)
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :