New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code convention for antd #1244
Labels
Comments
We can discuss questions like this: I think // Good
Button.propTypes = {
type: PropTypes.string,
};
// Bad
Button.propTypes = {
type: React.PropTypes.string,
}; |
// Good
Button.propTypes = {
type: PropTypes.string,
} // Bad
Button.propTypes = {
type: PropTypes.string,
}; 自从写js后看到分号总觉得不自在。。。 |
based on eslint-config-airbnb@6.x |
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Thanks to @waywardmonkeys, antd's code style is more consistent now :-)
And I think we had better to write those code convention in a document, so others can refer to it (as a complement or ESLint). I had created a wiki.
Maybe we could discuss code convention in this issue, and update the wiki when we draw a conclusion.
cc @afc163 @yiminghe
Maybe @hotoo is interested in this :-)
Note: antd's code style should be super set of eslint-config-airbnb.
The text was updated successfully, but these errors were encountered: