Interest in changing from React.createClass to extending React.Component?

[waywardmonkeys]

In the current repository, there are 113 instances where React.createClass is called and 17 where React.Component is extended. Is there interest in changing over to extending React.Component if someone does the boring work?

[afc163]

That will be a good improvement, pull request welcomes~

[waywardmonkeys]

Will do!

[benjycui]

It's a good chance to unified antd's code convention, see: #1244

[afc163]

Already done! Thank U @waywardmonkeys

[waywardmonkeys]

Not actually complete yet ... have to deal with event handler binding and then convert the remaining usages of React.createClass. :)

[benjycui]

Done: 0ebf6c2

Demos will keep using React.createClass:

1. We do not recommend our user to use ES7 now.
2. React.createClass will bind this automatically.

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.