feat: add description for Radio #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: add radio description docs
docs: add RadioGroup description doc
changlin2569
force-pushed
the
feat/add-description-for-radio
branch
from
457af9d
to
1f95e79
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 89.55% 89.83% +0.28%
==========================================
Files 144 144
Lines 3321 3315 -6
Branches 815 812 -3
==========================================
+ Hits 2974 2978 +4
+ Misses 293 283 -10
Partials 54 54 ☔ View full report in Codecov by Sentry. |
DiamondYuan
reviewed
Feb 4, 2024
src/Radio/index.less
Outdated
Comment on lines
99
to
100
| opacity: @radio-item-description; | ||
| color: @COLOR_TEXT_PRIMARY; |
DiamondYuan
reviewed
Feb 4, 2024
src/Radio/variable.less
Outdated
| @@ -19,3 +19,6 @@ | |||
|
|
|||
| /* color | disabled状态背景色 */ | |||
| @radio-disabled-background: @COLOR_GREY_CARD; | |||
|
|
|||
| /* radio 选项描述透明度 */ | |||
| @radio-item-description: 0.6; | |||
There was a problem hiding this comment.
这个删掉吧。 用 @COLOR_TEXT_ASSIST;
DiamondYuan
reviewed
Feb 4, 2024
src/Radio/index.axml.tsx
Outdated
| @@ -65,5 +72,14 @@ export default ( | |||
| </View> | |||
| </View> | |||
| </Label> | |||
| {typeof description === 'string' && ( | |||
There was a problem hiding this comment.
不要用 typeof , 这个在微信不支持。 用 description && 就可以了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持这个 issue 👉 #1042