Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt PyMAPDL to common plotter #2799

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Feb 20, 2024

Overview

This PR adapts PyMAPDL to the usage of the common PyAnsys plotter. It seems that part of PyMAPDL plotter is in another repo, so this work is partially done until I figure out how to modify this other part.

To summarize, on top of improving maintainability by keeping some common plotting code in the same location, this adds the following features:

  • Change view buttons
  • Displacement buttons
  • Ruler widget to measure distances in the plotter
  • Measure box widget
  • Option to filter the meshes by a regex
  • Option to add custom buttons to the plotter

Screenshot of how the plotter looks now:

image

Missing:

  • Document and add comments where needed
  • Adapt the other part of PyMAPDL
  • Adapt picker to use common plotter picker

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Feb 20, 2024
use_trame : bool, optional
Whether to use the trame interface or not, by default False.
theme : pv.DefaultTheme, optional
_description_, by default None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_description_, by default None
_description_, The default is ``None``.

A better description is needed here. I don't know what is meant by _description_.

Parameters
----------
points : List[float]
List of points of the labels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
List of points of the labels.
List of points of the labels.

.... of the labels or ... for the labels?

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry. You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 82.44275% with 23 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (3dcb798) to head (4cd06d4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
- Coverage   86.61%   83.82%   -2.80%     
==========================================
  Files          52       55       +3     
  Lines        9528     9623      +95     
==========================================
- Hits         8253     8066     -187     
- Misses       1275     1557     +282     

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry. You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry. You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry. You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants