-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adapt PyMAPDL to common plotter #2799
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
use_trame : bool, optional | ||
Whether to use the trame interface or not, by default False. | ||
theme : pv.DefaultTheme, optional | ||
_description_, by default None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_description_, by default None | |
_description_, The default is ``None``. |
A better description is needed here. I don't know what is meant by _description_
.
Parameters | ||
---------- | ||
points : List[float] | ||
List of points of the labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of points of the labels. | |
List of points of the labels. |
.... of the labels or ... for the labels?
for more information, see https://pre-commit.ci
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache in a new commit. This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2799 +/- ##
==========================================
- Coverage 86.61% 83.82% -2.80%
==========================================
Files 52 55 +3
Lines 9528 9623 +95
==========================================
- Hits 8253 8066 -187
- Misses 1275 1557 +282 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache in a new commit. This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache in a new commit. This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hello! 👋 Your PR is changing the image cache. So I am attaching the new image cache in a new commit. This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore you will see the actions showing in their status You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓 |
Overview
This PR adapts PyMAPDL to the usage of the common PyAnsys plotter. It seems that part of PyMAPDL plotter is in another repo, so this work is partially done until I figure out how to modify this other part.
To summarize, on top of improving maintainability by keeping some common plotting code in the same location, this adds the following features:
Screenshot of how the plotter looks now:
Missing: