Adding docker capability support to docker driver #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds cap_drop and cap_add support to docker driver. Adding and dropping docker capabilities is sometimes needed when testing containers that require to be managed by systemd. This commit also removes empty space characters from tox configuration :-)
|
@milosgajdos83 thanks for the PR. Could you also update the docker driver documentation as well. |
No apologies, I'm glad you caught those white space terds. I too have OCD 😸 . |
|
Also, we offer privileged, which has worked for me when testing systemd based services. Is priveleged more of a sledge hammer approach, and setting through cap a better option? |
|
Privileged mode can actually "mess" things up a bit in terms of security. I had a chat with @justincormack from Docker who explicitly told me to avoid it as it leads to insecure Docker containers. Adding and dropping |
milosgajdos
force-pushed
the
docker-caps
branch
from
983b710
to
5d0619d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
cap_dropandcap_addsupport to molecule's docker driver. Capability support has been available in docker-py since version1.2. Adding and dropping docker capabilities is needed when testing services that require to be managed bysystemd. You can read a bit about the background here and here. This PR also removes some empty space characters fromtoxconfiguration - sorry, I have an OCD :-)