[HOLD] Remove ANSIBLE_BASE_ROLE_PRECREATE only used by AWX #296
+1
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since ansible/awx#15087 is merged, this can be taken out of draft... right after a rebase. |
AlanCoding
force-pushed
the
no_precreate
branch
from
4b21fb8
to
a466b66
Compare
relrod
approved these changes
Apr 11, 2024
|
|
@newswangerd can you take a look at this and give it a thumbs up if we're good to merge? |
newswangerd
approved these changes
Apr 11, 2024
AlanCoding
added
question
|
We might hold off on merging (at least for a bit), as we're still not totally sure if other apps might use this. |
john-westcott-iv
changed the title
john-westcott-iv
changed the title
AlanCoding
added
blocked
|
Checked with @AlanCoding this is still on hold. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft initially, the work is going on separately in AWX, along with the role rename.
The AWX change is a blocker for merging this, but I want to be sure everything is passing here.
eda-server did not use this, and I do not anticipate galaxy_ng will either, but I await confirmation of that. If you plan to use this, we can keep it.