Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a role metadata endpoint for clients #238

Merged
merged 11 commits into from
May 23, 2024

Conversation

AlanCoding
Copy link
Member

this looks like

Screenshot from 2024-03-25 16-48-01

We could give the full data for test_app:

{
    "child_models": {
        "aap.immutabletask": {},
        "aap.instancegroup": {},
        "shared.organization": {
            "aap.cow": {},
            "aap.inventory": {},
            "aap.namespace": {
                "aap.collectionimport": {}
            },
            "aap.parentname": {},
            "aap.positionmodel": {},
            "shared.team": {},
            "aap.uuidmodel": {},
            "aap.weirdperm": {}
        }
    },
    "role_permissions": {
        "aap.collectionimport": [
            "aap.change_collectionimport",
            "aap.delete_collectionimport",
            "aap.view_collectionimport"
        ],
        "aap.cow": [
            "aap.say_cow",
            "aap.change_cow",
            "aap.delete_cow",
            "aap.view_cow"
        ],
        "aap.immutabletask": [
            "aap.cancel_immutabletask",
            "aap.view_immutabletask",
            "aap.delete_immutabletask"
        ],
        "aap.instancegroup": [
            "aap.change_instancegroup",
            "aap.delete_instancegroup",
            "aap.view_instancegroup"
        ],
        "aap.inventory": [
            "aap.update_inventory",
            "aap.change_inventory",
            "aap.delete_inventory",
            "aap.view_inventory"
        ],
        "aap.namespace": [
            "aap.change_namespace",
            "aap.delete_namespace",
            "aap.view_namespace",
            "aap.add_collectionimport",
            "aap.change_collectionimport",
            "aap.delete_collectionimport",
            "aap.view_collectionimport"
        ],
        "shared.organization": [
            "shared.change_organization",
            "shared.delete_organization",
            "shared.view_organization",
            "aap.update_inventory",
            "aap.add_inventory",
            "aap.change_inventory",
            "aap.delete_inventory",
            "aap.view_inventory",
            "aap.add_namespace",
            "aap.change_namespace",
            "aap.delete_namespace",
            "aap.view_namespace",
            "aap.add_collectionimport",
            "aap.change_collectionimport",
            "aap.delete_collectionimport",
            "aap.view_collectionimport",
            "shared.member_team",
            "shared.add_team",
            "shared.change_team",
            "shared.delete_team",
            "shared.view_team",
            "aap.say_cow",
            "aap.add_cow",
            "aap.change_cow",
            "aap.delete_cow",
            "aap.view_cow",
            "aap.add_uuidmodel",
            "aap.change_uuidmodel",
            "aap.delete_uuidmodel",
            "aap.view_uuidmodel",
            "aap.add_positionmodel",
            "aap.change_positionmodel",
            "aap.delete_positionmodel",
            "aap.view_positionmodel",
            "aap.I'm a lovely coconut",
            "aap.crack",
            "aap.add_weirdperm",
            "aap.change_weirdperm",
            "aap.delete_weirdperm",
            "aap.view_weirdperm",
            "aap.add_parentname",
            "aap.change_parentname",
            "aap.delete_parentname",
            "aap.view_parentname"
        ],
        "aap.parentname": [
            "aap.change_parentname",
            "aap.delete_parentname",
            "aap.view_parentname"
        ],
        "aap.positionmodel": [
            "aap.change_positionmodel",
            "aap.delete_positionmodel",
            "aap.view_positionmodel"
        ],
        "shared.team": [
            "shared.member_team",
            "shared.change_team",
            "shared.delete_team",
            "shared.view_team"
        ],
        "aap.uuidmodel": [
            "aap.change_uuidmodel",
            "aap.delete_uuidmodel",
            "aap.view_uuidmodel"
        ],
        "aap.weirdperm": [
            "aap.I'm a lovely coconut",
            "aap.crack",
            "aap.change_weirdperm",
            "aap.delete_weirdperm",
            "aap.view_weirdperm"
        ],
        "system": [
            "aap.add_collectionimport",
            "aap.view_collectionimport",
            "aap.change_collectionimport",
            "aap.delete_collectionimport",
            "aap.change_cow",
            "aap.view_cow",
            "aap.say_cow",
            "aap.add_cow",
            "aap.delete_cow",
            "aap.view_immutabletask",
            "aap.delete_immutabletask",
            "aap.add_immutabletask",
            "aap.cancel_immutabletask",
            "aap.add_instancegroup",
            "aap.change_instancegroup",
            "aap.delete_instancegroup",
            "aap.view_instancegroup",
            "aap.update_inventory",
            "aap.delete_inventory",
            "aap.change_inventory",
            "aap.view_inventory",
            "aap.add_inventory",
            "aap.add_namespace",
            "aap.view_namespace",
            "aap.change_namespace",
            "aap.delete_namespace",
            "shared.view_organization",
            "shared.add_organization",
            "shared.delete_organization",
            "shared.change_organization",
            "aap.add_parentname",
            "aap.change_parentname",
            "aap.view_parentname",
            "aap.delete_parentname",
            "aap.view_positionmodel",
            "aap.change_positionmodel",
            "aap.delete_positionmodel",
            "aap.add_positionmodel",
            "aap.view_uuidmodel",
            "aap.delete_uuidmodel",
            "aap.change_uuidmodel",
            "aap.add_uuidmodel",
            "aap.I'm a lovely coconut",
            "aap.change_weirdperm",
            "aap.crack",
            "aap.view_weirdperm",
            "aap.delete_weirdperm",
            "aap.add_weirdperm"
        ]
    }
}

In some cases, this might get a little big, but already test_app is close to what AWX would do.

@john-westcott-iv john-westcott-iv changed the title Add a role metadata endpoint for clients [WIP] Add a role metadata endpoint for clients Mar 28, 2024
Copy link

sonarcloud bot commented Apr 1, 2024

@AlanCoding
Copy link
Member Author

@AlanCoding AlanCoding force-pushed the role_metadata branch 2 times, most recently from 6b39585 to ad7b35e Compare April 30, 2024 18:26
@AlanCoding AlanCoding changed the title [WIP] Add a role metadata endpoint for clients Add a role metadata endpoint for clients May 10, 2024
@AlanCoding AlanCoding marked this pull request as ready for review May 10, 2024 20:41
@john-westcott-iv john-westcott-iv added the Ready for review This PR is ready for review either initially or comments have been address label May 16, 2024
Copy link
Contributor

@bhavenst bhavenst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great as far as I can tell!

@AlanCoding AlanCoding removed the Ready for review This PR is ready for review either initially or comments have been address label May 21, 2024
@AlanCoding
Copy link
Member Author

I got cold feet about the name here, I renamed it from role_permissions to allowed_permissions.

That seems like it makes way more sense to me right now.

Copy link

sonarcloud bot commented May 23, 2024

@AlanCoding AlanCoding merged commit cac0814 into ansible:devel May 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants