Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run post_remediation - quote group_names #128

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

diepes
Copy link
Contributor

@diepes diepes commented Dec 20, 2023

Overall Review of Changes:
Where run_audit.sh is called from ansible quote the group_name, as it can be a list containing a space.

To resolve a error

Issue Fixes:
Please list (using linking) any open issues this PR addresses
N/A
Resolves issue where there is more than one group, and the -g options fails due to space in command.
/opt/UBUNTU20-CIS-Audit/run_audit.sh ... -g ['all_dev', 'webservers_dev']

Enhancements:
Please list any enhancements/features that are not open issue tickets

How has this been tested?:

  • fixed issue in local env that happens when a host belongs to more than one group.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

uk-bolly
uk-bolly previously approved these changes Dec 21, 2023
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch

@uk-bolly uk-bolly dismissed their stale review December 21, 2023 08:16

gpg signature missing

@uk-bolly
Copy link
Member

hi @diepes

This is a great PR and good catch, unfortunatley the PR is not GPG signed so i am unable to accept it. GPG signature and sign off are both required.
Happy to merge if you can resolve this issue.

Many thanks

uk-bolly

@diepes diepes force-pushed the devel branch 2 times, most recently from 8271287 to 8278456 Compare December 22, 2023 10:41
@diepes
Copy link
Contributor Author

diepes commented Dec 22, 2023

hi @uk-bolly I added the signature.

Cheers,
diepes

@uk-bolly
Copy link
Member

uk-bolly commented Jan 9, 2024

hi @uk-bolly I added the signature.

Cheers, diepes

Hi @diepes

Thanks for following up unfortunetly as you can see from the actions it is still failing with unverified.
The error i am seeing with the signature is
The email in this signature doesn’t match the committer email.

many thanks
uk-bolly

Signed-off-by: Pieter Smit <github+gpg@vigor.nz>
@diepes
Copy link
Contributor Author

diepes commented Jan 16, 2024

hi @uk-bolly ,
I eventually got the gpg and signoff aligned and the Verified icon.

image

@uk-bolly uk-bolly merged commit 6884015 into ansible-lockdown:devel Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants