Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: service_catalog_info - to retrieve information about service catalog along with categories and items #342

Merged
merged 11 commits into from May 16, 2024

Conversation

tupyy
Copy link
Contributor

@tupyy tupyy commented Apr 16, 2024

This PR adds a module to retrieve information about service catalog along with categories and items

SUMMARY

This is part of Service Catalog features.

ISSUE TYPE
  • Feature Pull Request
ADDITIONAL INFORMATION
- name: Return all catalogs without categories but with items (brief information)
  servicenow.itsm.service_catalog_info:
    categories: false
    items_info: brief

- name: Return service catalog without categories but with items (brief information)
  servicenow.itsm.service_catalog_info:
    instance:
    sys_id: "{{ service_catalog.sys_id }}"
    categories: false
    items_info: brief

- name: Return service catalog with categories and with items (full information)
  servicenow.itsm.service_catalog_info:
    instance:
    sys_id: "{{ service_catalog.sys_id }}"
    categories: true
    items_info: full

Copy link

@tupyy tupyy self-assigned this Apr 16, 2024
@tupyy tupyy requested a review from mhjacks April 16, 2024 19:30
@tupyy tupyy marked this pull request as draft April 16, 2024 19:30
Copy link

@tupyy tupyy marked this pull request as ready for review April 17, 2024 09:25
Copy link

Copy link

changelogs/fragments/service_catalog_info.yml Outdated Show resolved Hide resolved
plugins/module_utils/service_catalog.py Outdated Show resolved Hide resolved
plugins/modules/service_catalog_info.py Outdated Show resolved Hide resolved
plugins/modules/service_catalog_info.py Outdated Show resolved Hide resolved
plugins/modules/service_catalog_info.py Outdated Show resolved Hide resolved
plugins/modules/service_catalog_info.py Outdated Show resolved Hide resolved
plugins/modules/service_catalog_info.py Outdated Show resolved Hide resolved
plugins/modules/service_catalog_info.py Outdated Show resolved Hide resolved
plugins/modules/service_catalog_info.py Outdated Show resolved Hide resolved
@Akasurde Akasurde changed the title Add service_catalog_info module New module: service_catalog_info - to retrieve information about service catalog along with categories and items Apr 17, 2024
Copy link

Copy link

Due to complexity of having a dict with dict as options, we changed the
modules args by flatting them.
Copy link

Copy link

@tupyy tupyy requested a review from Akasurde April 22, 2024 16:39
Copy link

Copy link
Collaborator

@mhjacks mhjacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor misspelling, I think?

plugins/module_utils/service_catalog.py Outdated Show resolved Hide resolved
plugins/module_utils/service_catalog.py Outdated Show resolved Hide resolved
@tupyy tupyy requested a review from mhjacks May 16, 2024 07:09
Copy link

@tupyy tupyy merged commit 582a81d into ansible-collections:main May 16, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants