Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of avi modules from community.network #506

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chandanapatnala
Copy link

SUMMARY

Remove the avi modules from community.network

ISSUE TYPE

  • Removal Pull Request

COMPONENT NAME

  • avi_actiongroupconfig
  • avi_alertconfig
  • avi_alertemailconfig
  • avi_alertscriptconfig
  • avi_alertsyslogconfig
  • avi_analyticsprofile
  • avi_api_session
  • avi_api_version
  • avi_applicationpersistenceprofile
  • avi_applicationprofile
  • avi_authprofile
  • avi_autoscalelaunchconfig
  • avi_backup
  • avi_backupconfiguration
  • avi_certificatemanagementprofile
  • avi_cloud
  • avi_cloudconnectoruser
  • avi_cloudproperties
  • avi_cluster
  • avi_clusterclouddetails
  • avi_controllerproperties
  • avi_customipamdnsprofile
  • avi_dnspolicy
  • avi_errorpagebody
  • avi_errorpageprofile
  • avi_gslb
  • avi_gslbgeodbprofile
  • avi_gslbservice
  • avi_gslbservice_patch_member
  • avi_hardwaresecuritymodulegroup
  • avi_healthmonitor
  • avi_httppolicyset
  • avi_ipaddrgroup
  • avi_ipamdnsproviderprofile
  • avi_l4policyset
  • avi_microservicegroup
  • avi_network
  • avi_networkprofile
  • avi_networksecuritypolicy
  • avi_pkiprofile
  • avi_pool
  • avi_poolgroup
  • avi_poolgroupdeploymentpolicy
  • avi_prioritylabels
  • avi_role
  • avi_scheduler
  • avi_seproperties
  • avi_serverautoscalepolicy
  • avi_serviceengine
  • avi_serviceenginegroup
  • avi_snmptrapprofile
  • avi_sslkeyandcertificate
  • avi_sslprofile
  • avi_stringgroup
  • avi_systemconfiguration
  • avi_tenant
  • avi_trafficcloneprofile
  • avi_user
  • avi_useraccount
  • avi_useraccountprofile
  • avi_virtualservice
  • avi_vrfcontext
  • avi_vsdatascriptset
  • avi_vsvip
  • avi_webhook

ADDITIONAL INFORMATION

The new collection is active on Galaxy here: https://galaxy.ansible.com/vmware/alb and on Github: https://github.com/vmware/ansible-collection-alb. This PR is to remove the avi modules from community.network.

@chaitanyaavi
Copy link

+1

@Andersson007
Copy link
Contributor

@chandanapatnala hello, thank you for the PR
The content is currently a part of the Ansible package, so I have several related questions:

  1. did you follow https://docs.ansible.com/ansible/devel/dev_guide/developing_collections_migrating.html#migrating-ansible-content-to-a-different-collection when moving content? @felixfontein could you please take a look? I think the modules first should be deprecated and then, in the next major release, the content should be actually removed.
  2. your new collection will be a part of the Ansible package, so it must satisfy the Collection checklist (here's also its longer more detailed version). For example, i don't see the collection follows SemVer; all the other stuff should be checked as well.
    If you don't want your collection be a part of the package let us know.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the current stance of the Steering Committee (SC) is that no modules can be migrated to collections that are not part of the Ansible package. This is something we can discuss on changing, but that needs discussion and approval by the SC first. As long as that decision stands, either your collection is added to Ansible first and then the plugins are moved, or the plugins are deprecated and then tombstoned (i.e. no redirects to your collection) in this collection.

So do you plan to submit your collection for inclusion in Ansible anyway (in which case let's do that first)? If not, we should start a discussion on whether we want to change the rule (https://github.com/ansible-community/community-topics/).

meta/runtime.yml Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

I created a community discussion in ansible-community/community-topics#167.

@chandanapatnala
Copy link
Author

Hi. According to the discussion as the redirection to the new collection is added in this pr-

avi_actiongroupconfig:
, can this pr be merged?

@felixfontein
Copy link
Collaborator

The discussion hasn't been concluded, so no.

@chandanapatnala
Copy link
Author

@felixfontein Hi , Is there any conclusion to the discussion ?

@chandanapatnala
Copy link
Author

@felixfontein Hi , Is there any conclusion to the discussion ? If yes , then I'll resolve the conflicts so that this pr can be merged

@felixfontein
Copy link
Collaborator

There is not. @ansible-collections/steering-committee a small reminder that ansible-community/community-topics#167 really needs to be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants