Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avi modules migration #288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

amolopcito
Copy link

SUMMARY

Migrate the avi modules to the vmware.alb namespace

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • avi_actiongroupconfig
  • avi_alertconfig
  • avi_alertemailconfig
  • avi_alertscriptconfig
  • avi_alertsyslogconfig
  • avi_analyticsprofile
  • avi_api_session
  • avi_api_version
  • avi_applicationpersistenceprofile
  • avi_applicationprofile
  • avi_authprofile
  • avi_autoscalelaunchconfig
  • avi_backup
  • avi_backupconfiguration
  • avi_certificatemanagementprofile
  • avi_cloud
  • avi_cloudconnectoruser
  • avi_cloudproperties
  • avi_cluster
  • avi_clusterclouddetails
  • avi_controllerproperties
  • avi_customipamdnsprofile
  • avi_dnspolicy
  • avi_errorpagebody
  • avi_errorpageprofile
  • avi_gslb
  • avi_gslbgeodbprofile
  • avi_gslbservice
  • avi_gslbservice_patch_member
  • avi_hardwaresecuritymodulegroup
  • avi_healthmonitor
  • avi_httppolicyset
  • avi_ipaddrgroup
  • avi_ipamdnsproviderprofile
  • avi_l4policyset
  • avi_microservicegroup
  • avi_network
  • avi_networkprofile
  • avi_networksecuritypolicy
  • avi_pkiprofile
  • avi_pool
  • avi_poolgroup
  • avi_poolgroupdeploymentpolicy
  • avi_prioritylabels
  • avi_role
  • avi_scheduler
  • avi_seproperties
  • avi_serverautoscalepolicy
  • avi_serviceengine
  • avi_serviceenginegroup
  • avi_snmptrapprofile
  • avi_sslkeyandcertificate
  • avi_sslprofile
  • avi_stringgroup
  • avi_systemconfiguration
  • avi_tenant
  • avi_trafficcloneprofile
  • avi_user
  • avi_useraccount
  • avi_useraccountprofile
  • avi_virtualservice
  • avi_vrfcontext
  • avi_vsdatascriptset
  • avi_vsvip
  • avi_webhook
ADDITIONAL INFORMATION

The new collection is active on Galaxy here: https://galaxy.ansible.com/vmware/alb and on Github: https://github.com/vmware/ansible-collection-alb. This PR is to migrate the modules in community.network over to the new collection. I tried to follow the Cisco PR (#142) but please let me know if there is anything that I am missing or needs to be corrected.


Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vmware.alb is not contained in Ansible, and there is no application for including it in Ansible (https://github.com/ansible-collections/ansible-inclusion/discussions). Therefore, this PR would mean that the content is permanently removed from Ansible.

I think this needs to be discussed first.

@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Jun 22, 2021
@tadeboro
Copy link

tadeboro commented Jun 22, 2021

Since this content is part of the ansible PyPI package, this PR cannot be merged as-is. There are two possible ways of moving forward:

  1. Get the vmware.alb collection included in the ansible package and then use the redirects to point to the new content.
  2. Deprecate the existing content now and add redirects at removal time. The content can then probably be removed in Ansible 6.

But this definitely needs some community feedback.

@felixfontein
Copy link
Collaborator

@tadeboro when the content is deprecated, we cannot add redirects until the point of removal, since redirects would break existing users now.

@tadeboro
Copy link

@tadeboro when the content is deprecated, we cannot add redirects until the point of removal, since redirects would break existing users now.

Grr, I misplaced the now in my previous comment. Now things should read better.

@ansibullbot
Copy link
Collaborator

@amolopcito This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on Libera.chat IRC

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor labels Nov 10, 2021
@ansibullbot ansibullbot added has_issue and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported feature This issue/PR relates to a feature request has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants